update run implementation #923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
update-run-function
branch
4 times, most recently
from
bddc19b to
7db5fd0
Compare
ryanzhang-oss
force-pushed
the
update-run-function
branch
from
7db5fd0 to
e3dcd78
Compare
jwtty
reviewed
Oct 27, 2024
| }).Complete(r) | ||
| } | ||
|
|
||
| // handleApprovalRequest find the CRP name from the approval request and enqueue the CRP to the updaterun controller queue |
There was a problem hiding this comment.
Why do we enqueue the CRP instead of the updateRun?
There was a problem hiding this comment.
good eye, should use TargetUpdateRun label
| @@ -1,43 +1,39 @@ | |||
| /* | |||
There was a problem hiding this comment.
The header should not be removed.
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/klog/v2" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| clusterv1beta1 "go.goms.io/fleet/apis/cluster/v1beta1" |
There was a problem hiding this comment.
It would be better to keep the original rename: clusterv1beta1
| // the rest of the clusters in the stage are not in the tobeDeletedBindings so it should be marked as delete succeeded | ||
| for _, clusterStatus := range existingDeleteStageClustersMap { | ||
| // make sure the cluster is marked as deleting | ||
| if !condition.IsConditionStatusTrue(meta.FindStatusCondition(clusterStatus.Conditions, string(placementv1alpha1.ClusterUpdatingConditionStarted)), updateRun.Generation) { |
There was a problem hiding this comment.
Is it possible for this condition to happen? The ClusterUpdating never started?
Co-authored-by: Wantong <[email protected]>
ryanzhang-oss
commented
Oct 31, 2024
| if errors.Is(err, errInitializedFailed) { | ||
| return runtime.Result{}, r.recordInitializationFailed(ctx, &updateRun, err.Error()) | ||
| } | ||
| return runtime.Result{}, err |
There was a problem hiding this comment.
the initialized failure error means terminating
| }).Complete(r) | ||
| } | ||
|
|
||
| // handleApprovalRequest find the CRP name from the approval request and enqueue the CRP to the updaterun controller queue |
There was a problem hiding this comment.
good eye, should use TargetUpdateRun label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer